libxkbcommon icon indicating copy to clipboard operation
libxkbcommon copied to clipboard

Reject unsupported flags

Open wismill opened this issue 1 month ago • 2 comments

Fail whenever an unsupported flag is used. See the discussion in #932

See also #942 to check valid flags properly.

@bluetech @whot this is probably better to fail explicitly (and early) rather than lie to the user.

It also enable indirectly to check for supported flags.

TODO:

  • [x] Single changelog entry
  • [x] Test all the functions with unsupported flags

wismill avatar Nov 20 '25 14:11 wismill

There is a problem that this change is in itself a breaking change. Might be fine though?

bluetech avatar Nov 28 '25 20:11 bluetech

I agree, but it seems the only proper behavior (see the description). Currently some functions follow this behavior and other do not. This MR makes the behavior consistent across the code base.

wismill avatar Nov 28 '25 20:11 wismill

Rebased & applied review

wismill avatar Dec 09 '25 07:12 wismill