crosscompile xkbcommon on linux for windows (1/2)

[awarnke]

Hello,

crosscompiling xkbcommon on linux (OpenSuse 15.4) for windows works, when applying some changes:

1. #ifdef _MSC_VER does not work when using the gnu cross compiler. I can fix this by setting this variable:

    meson configure -Dbuild.c_args=-D_MSC_VER=1
   

I guess this is just a hack, the right way would be to use another compiler variable. I'm no expert here - maybe _WIN32 is the right one, as used in other libraries:

src/fontconfig-2.13.96/src/fcxml.c:#ifdef _WIN32

src/libjpeg-turbo-2.1.3/tjexample.c:#ifdef _WIN32

src/expat-2.4.4/lib/xmlparse.c:#ifdef _WIN32

2. There is another issue with the tests, I guess I best create another ticket for this.

Just a note: in meson.build,

elif cc.get_argument_syntax() == 'msvc'

does also not work, the cross compiler might have a different signature.

PS: Some infos on setting up cross-compile of libxkbcommon for win are documented here: https://github.com/awarnke/crystal-facet-uml/tree/master/build/win

Kind Regards Andreas

[bluetech]

I'm no expert here - maybe _WIN32 is the right one, as used in other libraries:

No expert either, but this sounds OK to me, we can make this change.

elif cc.get_argument_syntax() == 'msvc' does also not work, the cross compiler might have a different signature.

Hmm this one does seem correct to me, here we do actually care about the specific compiler type.

What problem did this cause?

[bluetech]

The _MSC_VER -> _WIN32 change is done in #320, will be included in the next release.

[awarnke]

Thank you for checking the "cc.get_argument_syntax() == 'msvc' ". You are most likely right. If I stumble across this I'll tell you.

The _MSC_VER -> _WIN32 change looks good. Thank you for the fix!