Jeff Fisher

Results 149 comments of Jeff Fisher

Looks like this needs to get added to https://github.com/Azure/ms-rest-js/blob/01cfc78e2fe58d376cf1398f758d6e34415864c8/lib/webResource.ts#L12 Can you add some context about which service is using this?

Looking at this again, it seems like MERGE is not a standard request method: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods And this page makes it sound like PATCH is preferred: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-odata/59d5abd3-7b12-490a-a0e2-9d9324b91893 > Since MERGE is...

Technically I think you could set the method with `"MERGE" as any` and it would work, if you just want TS not to complain.

@elizabethhalper If I understand you correctly, is the request that the SDK validate blob contents were uploaded successfully and provide some kind of thrown error if this doesn't happen from...

> Looks good! The parallel execution is gone but since we never have a lot of packages under a service directory it doesn't matter much. Yeah, I figured out how...

Let me make sure I understand the issue here: - We only expose our MJS version by using the `module` field in `package.json`, which is *not* used by Node, but...

It seems like `.cjs` was added in Node 12, so we should be okay to use it.

@mpodwysocki this is related to the investigation you are doing for native Node module support

@icanfathom is this using a third party node canvas npm module? I'm mostly confused because the browser doesn't have buffers and Node doesn't have a DOM. 😅

@icanfathom I have made more and sillier mistakes! Please don't feel bad. I'm very happy you were able to get to the bottom of your trouble. @EmmaZhu perhaps putting some...