vorbis-tools icon indicating copy to clipboard operation
vorbis-tools copied to clipboard

Do not repeat garbage, peaking CPUs at 100%

Open sdaoden opened this issue 1 year ago • 1 comments

This is a possible solution for

https://github.com/xiph/vorbis-tools/issues/45

which works. Thanks for your consideration

sdaoden avatar May 09 '24 21:05 sdaoden

i mean there are really people which use these command line things. I do not even have a desktop environment and systemd! The patch works. Now silent.

sdaoden avatar Jun 08 '24 20:06 sdaoden

[Steffen Nurpmeso]

Hello! Cool that someone took maintainership, git fetched some!!

This is most likely a one-off, but thank you away. :)

You..do not seem have to adjusted indentation, so i want to say that the source code is a wild mix of this and that regarding tab and space indentation per se, no?

My major objection is that the indention of both r = lines in that block is not the same. In my view it show up as one and two characters in from "if (audio_buffer)", which tell me both lines do not use the same set of indentation characters, which I believe they should. It seem to me like most code above and below uses four char indentation per level, and I suggest you do the same here.

-- Happy hacking Petter Reinholdtsen

petterreinholdtsen avatar Apr 10 '25 14:04 petterreinholdtsen

ok, did. (i saw, then..) (P.S.: the email i got via github was double-escaped in the HTML part, like

 [Steffen Nurpmeso]<br>
> Hello!  Cool that someone took maintainership, git fetched some!!<br>
<br>

just in case you want to do something about that..)

sdaoden avatar Apr 10 '25 14:04 sdaoden

Look good to me, merged into master.

petterreinholdtsen avatar Apr 10 '25 15:04 petterreinholdtsen