rav1e icon indicating copy to clipboard operation
rav1e copied to clipboard

Hide full search speed setting from public api

Open KyleSiefring opened this issue 4 years ago • 2 comments

Thoughts?

KyleSiefring avatar Nov 05 '21 16:11 KyleSiefring

Mostly want it hidden so that I can add and remove it without multiple api changes.

I felt that using pub(crate) might end up being too error prone. Example: accidentally exposing things by writing pub instead of pub(crate).

One alternative would be to save the speed level and seed internal settings inside the encoder, but not inside api exposed structures.

KyleSiefring avatar Nov 05 '21 18:11 KyleSiefring

Until I cut a release any API you put move or change is fine and expected to change.

I'll make sure that the non-exhaustive and default() is in place tomorrow.

lu-zero avatar Nov 05 '21 18:11 lu-zero