rav1e icon indicating copy to clipboard operation
rav1e copied to clipboard

satd is being called twice when setting up subel for diamond search

Open KyleSiefring opened this issue 4 years ago • 1 comments

Once here: https://github.com/xiph/rav1e/blob/cfd4ea95c0503652eb6f94502d0578885d7f79ad/src/me.rs#L232-L254 And once in diamond search: https://github.com/xiph/rav1e/blob/cfd4ea95c0503652eb6f94502d0578885d7f79ad/src/me.rs#L729 since predictor is set as: https://github.com/xiph/rav1e/blob/cfd4ea95c0503652eb6f94502d0578885d7f79ad/src/me.rs#L433-L442

As far as I can tell, FullSearch does not do this.

KyleSiefring avatar Jul 14 '20 17:07 KyleSiefring

FYI, this doesn't seem super substantial when profiling.

KyleSiefring avatar Jul 14 '20 17:07 KyleSiefring