rav1e icon indicating copy to clipboard operation
rav1e copied to clipboard

Published 20 hours ago • verified publisher icon xiph

Change the minimum value of rdo_lookahead_frames to 0.

Open tdaede opened this issue 4 years ago • 5 comments

Has no effect on minimum latency, effectively changes the meaning of this value by 1.

tdaede avatar May 21 '20 17:05 tdaede

Coverage Status

Coverage decreased (-0.01%) to 83.508% when pulling d43930ff2b47a7635554d36f8d6af00b7e7fb27f on tdaede:rdo_lookahead_frames_0 into 7970d35ebb1424358b837c6e19b0cecf3cc6f8df on xiph:master.

coveralls avatar May 21 '20 17:05 coveralls

Can we rebase and land it?

lu-zero avatar Sep 14 '20 14:09 lu-zero

It needs another rebase, good for 0.5?

lu-zero avatar Jul 16 '21 20:07 lu-zero

I rebased this and it passes tests, but it really does need some closer look before we merge I think. I would almost suggest skipping 0.5.0 because of the high chance for regressions.

tdaede avatar Jul 21 '21 00:07 tdaede

I happened upon this PR in my review queue. Is this still something we want to do? I'm assuming given the time since this PR was created, there's going to be some nasty merge conflicts.

shssoichiro avatar Apr 20 '22 06:04 shssoichiro