rav1e icon indicating copy to clipboard operation
rav1e copied to clipboard

Add rav1e_config_parse_bool

Open lu-zero opened this issue 5 years ago • 5 comments

Act as helper to set boolean values.

Fixes: https://github.com/xiph/rav1e/issues/2155

lu-zero avatar Feb 06 '20 15:02 lu-zero

I feel like using parse_int with 0 and 1 feels more like idiomatic C, but also I don't have a stong opinion on it.

@tdaede any opinion from you?

dwbuiten avatar Feb 06 '20 15:02 dwbuiten

If you tested it I'd go and merge it

lu-zero avatar Feb 13 '20 04:02 lu-zero

Poke.

lu-zero avatar Dec 28 '20 17:12 lu-zero

I'd land it for 0.5.

lu-zero avatar Jul 16 '21 20:07 lu-zero

Coverage Status

Coverage increased (+0.004%) to 83.525% when pulling 9dcd9726c2b903c4e203fb3cf9a82bbda91576a4 on rust-av:capi-parse_bool into 7970d35ebb1424358b837c6e19b0cecf3cc6f8df on xiph:master.

coveralls avatar Jul 16 '21 21:07 coveralls

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e006c0e) 88.24% compared to head (5a8deb9) 88.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files          88       88           
  Lines       28210    28210           
=======================================
  Hits        24893    24893           
  Misses       3317     3317           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 19 '23 09:12 codecov[bot]