opus icon indicating copy to clipboard operation
opus copied to clipboard

Fix CodeQl overflow warnings

Open ann0see opened this issue 3 years ago • 2 comments

We're building Opus via our CI with CodeQl and it seems to give overflow warnings - although they might be invalid:

image

It would be good to investigate (and potentially fix them)?

ann0see avatar Mar 28 '22 11:03 ann0see

I haven't checked all of them, but all of the ones I've looked at are logically just completely impossible to overflow, they're always working with small numbers. A handful of overflows have been found and fixed over the years, but these don't seem to qualify?

silverbacknet avatar Mar 28 '22 12:03 silverbacknet

Probably? I don’t know the code but I found it very annoying to see it in CodeQL, so I opened this issue. Do you think anything can be done to fix it

ann0see avatar Mar 28 '22 13:03 ann0see