Snorlax
Snorlax
> Not all (C++) headers end with .h. (Nor, indeed, any extension at all, sadly.) Suggestion: Flip the if statement the other way, checking if the file has a source...
For headers how about we divide the header extractor into these steps 1. query targets which attrs(hdrs&srcs) contains the header file. If there has other source extensions like .c then...
> Hey, @xinzhengzhang! I wanted to check back in on these to see how you're doing. Thanks for all your efforts; I know this is hard to get right! Sorry...
Sorry again for the long time of inactivity due to work. I just rebased the main branch and squash the commits. Regarding the header lib problem discussed above, I have...
I have simplify the loop using nested function and fixed no-action case in _get_commands https://github.com/hedronvision/bazel-compile-commands-extractor/pull/99/commits/251bbb2cc281b77b508538c3afc9a38fecfee808 Terminate the loop if header has been found or reached the max attempt times https://github.com/hedronvision/bazel-compile-commands-extractor/pull/99/commits/8df22384e2cd1f6a30c4331eef8965c047c41516...
Hi, Chris @cpsauer I would like to ask if there is anything else that needs to be modified for this pr? In addition, I want to change my vscode extension...
Since the entire aquery logic is nested, there are many conflicts. I just rebase main and push -f
Thanks for getting back to me. I'll do my best to identify and fix the bugs. Have a great trip!
Sorry, maybe due to preconceived notions, although I reviewed it again, I didn't find too many bugs... if it's ok, you can directly modify my pr as you want.
> TODO discuss the below. > If we're focusing on a header, we return just that header. Why? Only source files are useful for background indexing, since they include headers,...