Build failure fix changed <angled> to "quotes" on import <UIView+Reach.h>

[hammadzz]

Fixes #371

[Crash--]

Thank you for this PR.

Can you tell me what is the RN version you use? Since RN 0.40 iOS headers has been moved (cf https://github.com/facebook/react-native/releases/tag/v0.40.0).

Also it's pretty weird since headers should have been #import <React/UIView+React.h>. Can you try with this one?

[hammadzz]

@Crash-- from my package.json "react-native": "^0.49.5"

This issue is seen with another library as well. I can make a new branch and give that React/UIView+React.h as shot. I also suspect another thing with the way I was double adding react from pods and node_modules. So perhaps I don't even need a fix. Will by tomorrow

[Sebastian-Neubert]

+1

[Tamiyadd]

same problem here :( found a solution?

[hammadzz]

@Tamiyadd can you check if you have react in your pods file and your package.json? I suspect it was that but I never got back to checking. I just used my fork (this pull request) to get around the issue. I guess I will get back to it when I try to update this library. :(

Kind of tied up with finishing my project.

[Tamiyadd]

@hammadzz yes i have react native core in my podfile :(

[hammadzz]

@Tamiyadd try without it.

[Tamiyadd]

@hammadzz if i remove react from podfile pod will install react 0.11.0

[riwu]

I'm facing the same issue as well. I'm using the detached expo sdk which tends to mess up linking of other native libraries.

Podfile:

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '9.0'

target 'slions' do
  pod 'ExpoKit',
    :git => "http://github.com/expo/expo.git",
    :tag => "ios/2.3.3",
    :subspecs => [
      "Core",
      "CPP"
    ]

  pod 'React',
    :path => "../node_modules/react-native",
    :subspecs => [
      "Core",
      "ART",
      "RCTActionSheet",
      "RCTAnimation",
      "RCTCameraRoll",
      "RCTGeolocation",
      "RCTImage",
      "RCTNetwork",
      "RCTText",
      "RCTVibration",
      "RCTWebSocket",
      "DevSupport",
      "CxxBridge"
    ]
  pod 'yoga',
    :path => "../node_modules/react-native/ReactCommon/yoga"
  pod 'DoubleConversion',
    :podspec => "../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec",
    :inhibit_warnings => true
  pod 'Folly',
    :podspec => "../node_modules/react-native/third-party-podspecs/Folly.podspec",
    :inhibit_warnings => true
  pod 'GLog',
    :podspec => "../node_modules/react-native/third-party-podspecs/GLog.podspec",
    :inhibit_warnings => true


  pod 'react-native-video', :path => '../node_modules/react-native-video'

  pod 'react-native-fetch-blob', :path => '../node_modules/react-native-fetch-blob'

  pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'

  pod 'react-native-material-kit', :path => '../node_modules/react-native-material-kit'

  post_install do |installer|
    installer.pods_project.main_group.tab_width = '2';
    installer.pods_project.main_group.indent_width = '2';

    installer.pod_targets.each do |target|

    if target.pod_name == 'ExpoKit'
      target.native_target.build_configurations.each do |config|
        config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
        config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << 'EX_DETACHED=1'
        # needed for GoogleMaps 2.x
        config.build_settings['FRAMEWORK_SEARCH_PATHS'] ||= []
        config.build_settings['FRAMEWORK_SEARCH_PATHS'] << '${PODS_ROOT}/GoogleMaps/Base/Frameworks'
        config.build_settings['FRAMEWORK_SEARCH_PATHS'] << '${PODS_ROOT}/GoogleMaps/Maps/Frameworks'
      end
    end


    if target.pod_name == 'AppAuth'
      target.native_target.build_configurations.each do |config|
        config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
      end
    end
    # Build React Native with RCT_DEV enabled
    next unless target.pod_name == 'React'
    target.native_target.build_configurations.each do |config|
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << 'RCT_DEV=1'
    end

    end
  end
end

[pencilcheck]

I would like to see this merged, it fixed the error somehow.

[RobTS]

+1

[Tamiyadd]

• 1

[ericorruption]

Any news on this one?

[badoet]

merge this please? any reason why this is not merged? @xinthink

[Sebastian-Neubert]

I don't know. This makes semantically no difference.

[swansontec]

I have opened a competing pull request, #409. This pull request contains the correct solution according to the react-native 0.40.0 release notes. The single-quote vs. double-quote thing was a red herring. The real problem is that the header moved.