react-native-material-kit icon indicating copy to clipboard operation
react-native-material-kit copied to clipboard

typescript support

Open hatpick opened this issue 8 years ago • 14 comments

Hello, Is there any plan for supporting typescript? Is there any DefinitelyTyped file for this library?

hatpick avatar Jul 21 '17 07:07 hatpick

No plan for supporting typescript ATM

Crash-- avatar Jul 21 '17 07:07 Crash--

@hatpick I'm currently working on it.

iRoachie avatar Jul 21 '17 14:07 iRoachie

@iRoachie do you have a repo in progress? Can you share it with us?

hatpick avatar Jul 21 '17 17:07 hatpick

@hatpick No but i guess i probably should make one. I'm going to submit them to DefinitelyTyped though so they'll be easier to maintain, update. Gimme 20 mins

iRoachie avatar Jul 21 '17 17:07 iRoachie

@iRoachie any progress? Can you email me them in the meantime if it takes long for them to approve?

hatpick avatar Jul 21 '17 18:07 hatpick

@hatpick Started here https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18289

iRoachie avatar Jul 21 '17 18:07 iRoachie

@iRoachie good job, it's gonna be huge tho, do you have all of it covered?

hatpick avatar Jul 21 '17 18:07 hatpick

@hatpick Not as yet. I'm adding component by component. Will make a checklist soon

iRoachie avatar Jul 21 '17 18:07 iRoachie

@iRoachie check this out

https://gist.github.com/hatpick/eb061a0c27cd6dcb215cee0a88e10e1a

hatpick avatar Jul 27 '17 05:07 hatpick

Added. @types/react-native-material-kit

iRoachie avatar Sep 02 '17 04:09 iRoachie

@iRoachie

not support all property

message: 'Property 'coloredButton' does not exist on type 'typeof MKButton'.'

Risbot avatar Feb 16 '18 17:02 Risbot

@risbot this is on the builder you’re referring to?

iRoachie avatar Feb 17 '18 07:02 iRoachie

@iRoachie it is this part of code MKButton.coloredButton() function coloredButton() is not defined in typescript.

Risbot avatar Feb 17 '18 11:02 Risbot

You can make a pull request over at DefinitelyTyped. The typings are here https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native-material-kit/index.d.ts

iRoachie avatar Feb 18 '18 22:02 iRoachie