Real-ESRGAN icon indicating copy to clipboard operation
Real-ESRGAN copied to clipboard

Published 20 hours ago • verified publisher icon xinntao

Enable cpu usage

Open tejaswivg opened this issue 2 years ago • 2 comments

These changes fix some issues I had when torch is used without cuda (cpu only).

tejaswivg avatar Jan 29 '23 11:01 tejaswivg

I implemented #561 as an alternative approach (wasn't intentionally duplicating your effort; I wrote my PR last week before yours was submitted). I like your approach of defaulting to CPU mode if CUDA isn't available, but I think it would be desirable to allow the user to explicitly choose CPU even if CUDA is available (as my PR does). Feel free to borrow pieces of my PR; seems desirable to combine the respective strengths of both PR's.

Splendide-Imaginarius avatar Jan 30 '23 18:01 Splendide-Imaginarius

I implemented #561 as an alternative approach (wasn't intentionally duplicating your effort; I wrote my PR last week before yours was submitted). I like your approach of defaulting to CPU mode if CUDA isn't available, but I think it would be desirable to allow the user to explicitly choose CPU even if CUDA is available (as my PR does). Feel free to borrow pieces of my PR; seems desirable to combine the respective strengths of both PR's.

@xinntao any thoughts on this?

tejaswivg avatar Feb 04 '23 07:02 tejaswivg