newrelic-grape icon indicating copy to clipboard operation
newrelic-grape copied to clipboard

All transations in New Relic collected under Proc#call

Open andoriyu opened this issue 11 years ago • 17 comments
trafficstars

Did I miss anything?

andoriyu avatar Jul 01 '14 01:07 andoriyu

@andoriyu sorry, what do you mean? anything wrong in newrelic-grape?

flyerhzm avatar Jul 02 '14 15:07 flyerhzm

Basically it doesn't work with 3.9.x. All transactions grouped into single one.

andoriyu avatar Jul 02 '14 16:07 andoriyu

@andoriyu I will try later

flyerhzm avatar Jul 03 '14 16:07 flyerhzm

newrelic_rpm 3.9.x added support for middleware instrumentation. But all Grape transactions appear under Proc#call screenshot 2014-07-15 12 24 30

thetamind avatar Jul 15 '14 17:07 thetamind

Same here. Any way to fix this?

frank-lsf avatar Jul 16 '14 00:07 frank-lsf

I spend sometime trying to fix that, but couldn't and simply checked out 3.8.x.

andoriyu avatar Jul 16 '14 00:07 andoriyu

This gem is not compatible with automatic middleware instrumentation that was introduced in 3.9.0 NewRelic gem [1]. However you can disable this feature by setting disable_middleware_instrumentation: true in newrelic.yml[2].

Here [3] is an example how it can be implemented with keeping middleware instrumentation on.

[1] https://github.com/newrelic/rpm/blob/master/CHANGELOG [2] https://docs.newrelic.com/docs/ruby/rack-middlewares#disabling [3] https://gist.github.com/maciejmajewski/d4fe02efded8ebf3d31e

maciejmajewski avatar Jul 21 '14 12:07 maciejmajewski

@maciejmajewski I see your gist, looks good, could you send me a pull request.

I don't have any grape project recently, it's a bit hard for me to maintain this repo, are you interested in maintaining it?

flyerhzm avatar Jul 26 '14 09:07 flyerhzm

@flyerhzm I don't think I'll find time to maintain this gem, but I'll prepare later a pull-request to make it work correctly with latest NewRelic version

maciejmajewski avatar Aug 06 '14 09:08 maciejmajewski

@maciejmajewski I would majorly appreciate that PR. :)

jmondo avatar Sep 21 '14 18:09 jmondo

Would love to see a fix for this - I've tried to work around it myself, but can't seem to get anything working. I tried [3] om @maciejmajewski's post, but to no avail (everything still comes in under Proc#call)

Any pointers?

rayh avatar Sep 28 '14 23:09 rayh

I will prepare a PR this week.

maciejmajewski avatar Sep 29 '14 07:09 maciejmajewski

hi all, sorry for the late, but I have released newrelic-grape 2.0.0, which fix this issue, please try and let me know if it works, thanks

flyerhzm avatar Oct 20 '14 07:10 flyerhzm

I still see Proc#call with 2.0.0 and newrelic_rpm 3.9.8.273. Am I missing anything?

elado avatar Dec 08 '14 23:12 elado

same here with newrelic 3.9.9.275, downgraded to 3.8.1.221 and seems fine

forresty avatar Jan 23 '15 09:01 forresty

Hey, issue still occurs on newrelic_rpm 3.10.0.279 and newrelic-grape 2.0.0.

swistaczek avatar Mar 17 '15 07:03 swistaczek

Everything is fine with:

  • newrelic-grape (2.0.0)
  • newrelic_rpm (3.12.0.288)

Can be closed now.

dmitry avatar Sep 22 '15 07:09 dmitry