appstream icon indicating copy to clipboard operation
appstream copied to clipboard

Screenshots composed with appstreamcli compose look a bit blurry compared to appstream-util

Open bbhtt opened this issue 1 year ago • 3 comments

Hi,

With this current metainfo file https://github.com/lwindolf/liferea/blob/b8c934f3a627ef35060e5e6d342275ee72fdfc2c/net.sourceforge.liferea.appdata.xml.in#L33-L70

Using org.flatpak.Builder 1.4.1 and appstreamcli 1.0.1

The thumbnail images looks a bit blurry compared to the one generated by appstream-util.

appstreamcli ([email protected]):

image-1_752x590@1

appstream-util:

net sourceforge liferea-5b97a2051866698942c536e94169b6a8

I looked at the screenshot code a bit, most of it seems similar to appstream-util, so not sure what's causing the difference. (optipng was not used)

bbhtt avatar Feb 16 '24 12:02 bbhtt

We might need to look at the source too, there also has been a report, that the old screenshots were sharpened? So maybe we just lost that?

https://github.com/flathub/flathub/issues/2995

razzeee avatar Feb 17 '24 10:02 razzeee

This really can't just be my eyesight or my monitor, but are the AppStream-generated screenshot thumbnails really blurrier? They look exactly the same to me, only that the appstream-util one is smaller (but if you scale them to the same size in GIMP, I see no difference). I also only looked at the example above.

Using optipng should not change the image quality.

If sharpening helps, we could add that, but I'm not sure if adding it unconditionally is great - sometimes this kind of image processing produces annoying artifacts in some corner cases that people won't like.

ximion avatar Feb 18 '24 03:02 ximion

IMO if the old ones were sharpened, that's something we should get rid of, so this would be an non issue

razzeee avatar Feb 18 '24 13:02 razzeee