francinette icon indicating copy to clipboard operation
francinette copied to clipboard

All tests passes, although the Makefile doesn't work properly

Open m4nnb3ll opened this issue 2 years ago • 0 comments

The Moulinette throws back my project twice, both times it is Makefile related problem:

The 1st problem:

I was using -I. flag in the implicit rule of compilation(%.o: %.c), and i did put by mistake <libft.h> instead of "libft.h" in one of the files, but the Makefile just worked seamlessly without throwing any errors.(the three flags were used: -Wall -Wextra -Werror). The Moulinette doesn't seem to use the -I. flag in the first compilation test, and that threw an error, so I had to remove the -I. flag to fix the problem.

The 2nd problem(which i find a more serious issue):

The tests don't test the libft.a library for compilation, my Makefile was creating the library libft.a with only one object file(ft_isalpha.o), and that was due to my misunderstanding(i was using $< instead of $^), when the Moulinette tried to test with my libft.a it threw and error because the next function to test(ft_isdigit) was not included in the library.

I hope that i explained the problem well, and i hope that the problems that cost me 6 evaluation points (and lot of time) get fixed, so further students won't fall for the same problem.

m4nnb3ll avatar Oct 25 '22 18:10 m4nnb3ll