XiChen

@smengcl PTAL. Thanks

> Thanks @xichen01 for the big patch. lgtm > > Only concern left from my side is the one regarding snapshot diff: [#4188 (comment)](https://github.com/apache/ozone/pull/4188#discussion_r1559096505) Have modified.

@sadanand48 @kaijchen Okay, I'll check this PR, I've looked at it briefly before, but I haven't identified possible reasons causing ITestOzoneContractMkdir flaky.

> @xichen01 I can help take a look if you need. yeah, thank you, I think it would be helpful, and if you have time, I will prioritize this issue...

this is latest MR https://github.com/apache/ozone/pull/4038 @kaijchen I think the issue of `ITestOzoneContractMkdir` should have been fixed, can you run it multiple times to confirm the fix, I have run it...

@mohan3d > At the time of implementing this I had no imagination on how the ACLs will work on this. If I recall it was restricted for the owner. Yes,...

> @xichen01 , thanks a lot for working on this! How about add a `StringWithByteString` class as below? Than, it won't have any additional cache lookups. > > ```java >...

@szetszwo Thanks for your reply > If there are many DatanodeDetails instances , we probably should cache DatanodeDetails instances instead of the ByteString inside the DatanodeDetails. - But `DatanodeDetails` is...

> This PR also adds Guava Cache with some hard coded size (50,000). .... In fact, the reason I use Guava Cache is to prevent accidents from occurring that would...

@szetszwo Thanks for your new comments and patch, I have applied the patch.