xibz

Results 56 comments of xibz

After playing around some with the JSON schema, I believe `anyOf` should be `oneOf`. I noticed you did mention that `oneOf` would complain about the issue, but would still be...

I think `anyOf` is still valid in this case, but I could see why it is confusing. I think the more confusing portion is here ```json "anyOf": [ { "type":...

@davidB Because a string'd enum is different than an normal enum, e.g. C where it is an integer, and we also want to explicitly say it is a string, and...

@davidB No, they don't have to be strings. We are explicitly saying that they **are** strings. This is important because anyone wanting to make a change to the spec, will...

@davidB Oh, sorry, I misunderstood what you are asking. It's not an array in practice. That's just part of the spec. Basically it is saying, we have some `enum` value,...

Oh! I completely mistook what you were saying! Gotcha! hahah, now I see the confusion. Okay, yea, this is definitely not modeled correctly. Okay, I will have this fixed with...

Okay, I think I understand what was trying to be modeled. So basically we want any string, but want to provide some defaults, like `low`, `medium`, `high` in the SDKs....

@davidB Examples are nice, but I think it's really important to have the values modeled in the SDKs. I believe `examples`, will not be used in code generation? So it...

@davidB ```go type Priority string var Low Priority = "low" var Medium Priority = "medium" var High Priority = "high" ``` Something like this would be sufficient Then if a...

@afrittoli I think that makes sense except for generating based on `examples`. Mostly that `examples` does not seem like the appropriate place to generate defaults from. However, if we want...