xibo
xibo copied to clipboard
Dataset tables always created with charset utf8 instead of utf8mb4
With #3044 collation was switched to utf8mb4 to support emojis. Now I upgraded our xibo to v4 and have noticed that it still doesn't work to include emojis in data sets. So I was able to find the following line:
https://github.com/xibosignage/xibo-cms/blob/49f018fd9fe64fcd417d7c2ef96078bd7b2b88b7/lib/Entity/DataSet.php#L1101
Changing line from
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=1
to
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 AUTO_INCREMENT=1
fixes the problem, I already tried it on our system.