Qi Xiao

Results 250 comments of Qi Xiao

> The limited Elvish developer resources are better spent on issues that are unique to Elvish rather than working around shortcomings of the packages, including the Go stdlib, Elvish depends...

> So, to condense it down: Basically, `if windows` requires it's very own "shell escaping" to work around the implicit `cmd.exe /c` call? Hm... o.o Interesting. Yeah. > I'll triage...

The [indexing expression](https://elv.sh/ref/language.html#indexing) allows multiple values as the indexee, so you can use: ```elvish var y = [(all $x)[name]] var y = [$@x[name]] ``` I figure these are not too...

Indeed feels like a bug to me, should be easy to fix.

Huh, I hope my comment was clear that I think the behavior should be changed.

Hmm there's something deeper here. In general `Widget` implementations assume that its `Render` method is never called with a height of 0, but that pre-condition is broken somewhere.

OK, it's a simple one 🤦 https://github.com/elves/elvish/blob/3889bd05abc3a6b709c234ad658621d8fea0640a/pkg/cli/tk/combobox.go#L51

Hi, sorry for not getting to this. I've wanted to try Nix for a while, so I've been sitting on this PR thinking that I'd get to it once I...

Thanks. I made some updates on the branch itself.

Thanks for the fix! I'm slightly puzzled how this fix works - it seems there's something deeper that's wrong. I'll look into this a bit more and get back to...