isomorphic-router-demo icon indicating copy to clipboard operation
isomorphic-router-demo copied to clipboard

package.json fixed versions

Open asicfr opened this issue 6 years ago • 3 comments

Thanks for this great starter kit. Only on question, i used to fix all version (no tilde and caret) to avoid pb in CICD. Why do not you fix dependency versions ? Thanks

asicfr avatar Mar 20 '18 12:03 asicfr

@asicfr I'm not sure what you are asking. This is a demo project and not a production ready project. I installed the dependencies and third party middlewares as needed with npm install --save [middleware].

xiaoyunyang avatar Mar 21 '18 03:03 xiaoyunyang

Sorry, i have poor english. I mean why you don't use : npm install XXX --save --save-exact ?

asicfr avatar Mar 21 '18 08:03 asicfr

Honestly I didn't think to do that. If you want to try make this project CICD-ready, feel free to submit a PR.

xiaoyunyang avatar Mar 27 '18 22:03 xiaoyunyang