superlu_dist
superlu_dist copied to clipboard
xiaoyeli
Eliminate creationof superlu_dist_config.h in the source directory. …
…Not needed and makes the source directory look like something needs to be added.
I need this in original SRC/. I am supporting both CMake build and legacy "make.inc" user-editing style (still a lot of users prefer the later.) That means, users can go to original EXAMPLE/, compile and run the examples without bothering cmake. In this case, need to include SRC/*.h files.
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they want to, no?
On 1/21/18 12:35 PM, X. Sherry Li wrote:
I need this in original SRC/. I am supporting both CMake build and legacy "make.inc" user-editing style (still a lot of users prefer the later.) That means, users can go to original EXAMPLE/, compile and run the examples without bothering cmake. In this case, need to include SRC/*.h files.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359273996, or mute the thread https://github.com/notifications/unsubscribe-auth/ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld.
Even with cmake, I use make.inc.in template to generate a make.inc, so that the users can use this to play with the source files in EXAMPLE/, and use these flags in their apps. Users cannot easily work with the examples in the build tree.
On Sun, Jan 21, 2018 at 11:44 AM, jrobcary [email protected] wrote:
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they want to, no?
On 1/21/18 12:35 PM, X. Sherry Li wrote:
I need this in original SRC/. I am supporting both CMake build and legacy "make.inc" user-editing style (still a lot of users prefer the later.) That means, users can go to original EXAMPLE/, compile and run the examples without bothering cmake. In this case, need to include SRC/*.h files.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359273996 , or mute the thread <https://github.com/notifications/unsubscribe-auth/ ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359274715, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMq99E0pVDKU3YOItbqOKWQvq7rq1Trks5tM5OugaJpZM4Rl7ld .
Not sure I understand, but no problem. I can certainly live without this change!
On 1/21/18 12:54 PM, X. Sherry Li wrote:
Even with cmake, I use make.inc.in template to generate a make.inc, so that the users can use this to play with the source files in EXAMPLE/, and use these flags in their apps. Users cannot easily work with the examples in the build tree.
On Sun, Jan 21, 2018 at 11:44 AM, jrobcary [email protected] wrote:
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they want to, no?
On 1/21/18 12:35 PM, X. Sherry Li wrote:
I need this in original SRC/. I am supporting both CMake build and legacy "make.inc" user-editing style (still a lot of users prefer the later.) That means, users can go to original EXAMPLE/, compile and run the examples without bothering cmake. In this case, need to include SRC/*.h files.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub
<https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359273996
, or mute the thread <https://github.com/notifications/unsubscribe-auth/ ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub
https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359274715,
or mute the thread
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359275554, or mute the thread https://github.com/notifications/unsubscribe-auth/ABX9TDN5oGm5Zwj5Qqqmgt0-n7zg_VDcks5tM5YIgaJpZM4Rl7ld.
The EXAMPLE/ in build tree only have executables, so users cannot change it to match their apps need. For convenience, I am still expose make.inc (cmake generated from make.inc.in) to the users, which contains the flags used while building. Users can take this info and the code in source tree to merge in their apps.
Do you have better ideas how to make this easy for the users?
On Sun, Jan 21, 2018 at 11:56 AM, jrobcary [email protected] wrote:
Not sure I understand, but no problem. I can certainly live without this change!
On 1/21/18 12:54 PM, X. Sherry Li wrote:
Even with cmake, I use make.inc.in template to generate a make.inc, so that the users can use this to play with the source files in EXAMPLE/, and use these flags in their apps. Users cannot easily work with the examples in the build tree.
On Sun, Jan 21, 2018 at 11:44 AM, jrobcary [email protected] wrote:
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they want to, no?
On 1/21/18 12:35 PM, X. Sherry Li wrote:
I need this in original SRC/. I am supporting both CMake build and legacy "make.inc" user-editing style (still a lot of users prefer the later.) That means, users can go to original EXAMPLE/, compile and run the examples without bothering cmake. In this case, need to include SRC/*.h files.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub
<https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359273996
, or mute the thread <https://github.com/notifications/unsubscribe-auth/ ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub
<https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359274715 ,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ ALMq99E0pVDKU3YOItbqOKWQvq7rq1Trks5tM5OugaJpZM4Rl7ld>
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359275554 , or mute the thread <https://github.com/notifications/unsubscribe- auth/ABX9TDN5oGm5Zwj5Qqqmgt0-n7zg_VDcks5tM5YIgaJpZM4Rl7ld>.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xiaoyeli/superlu_dist/pull/22#issuecomment-359275699, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMq90xZ4QDTToASRP52dSTBZ6oCV2bHks5tM5aGgaJpZM4Rl7ld .