superlu icon indicating copy to clipboard operation
superlu copied to clipboard

Published 20 hours ago • verified publisher icon xiaoyeli

Fixes broken Windows CI builds.

Open gruenich opened this issue 1 year ago • 1 comments

[example] Remove unnecessary include unistd.h from ?itersol.c

gruenich avatar Jul 22 '24 20:07 gruenich

@xiaoyeli Please merge this to fix the CI tests for windows.

  1. Why were the wrong includes of unistd.h added back to the examples?
  2. Why was a merge request accepted, that failed the CI tests? That is the purpose of the tests. If you have issues with fixing broken CI prior to merging, please reach out to me and I try to help.

gruenich avatar Jul 22 '24 20:07 gruenich

We are using macro files to generate 4 precision files. While I was updating the macro files for some other bug fixes, I missed this fix.

xiaoyeli avatar Jul 26 '24 02:07 xiaoyeli

Now I updated the macro file with this fix.

xiaoyeli avatar Jul 26 '24 02:07 xiaoyeli