superlu icon indicating copy to clipboard operation
superlu copied to clipboard

exit(1) and fprintf in ILU

Open LiuZhexuan opened this issue 11 months ago • 4 comments

In ilu_dpivotL, if singularity is detected, exit(1) will be triggered and cause the whole program be terminated. This is inconsistent with what happend in LU. In dpivotL, singularity will only cause LU return with some error info.

The way dpivotL do is more reasonable since superLU user may want to recover from singularity (e.g. add diagnoal matrix to original matix).

LiuZhexuan avatar Mar 14 '24 03:03 LiuZhexuan

Fixed this behavior; not to exit(1).

xiaoyeli avatar Mar 31 '24 17:03 xiaoyeli

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

gruenich avatar Apr 09 '24 13:04 gruenich

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

Thanks, I pulled master branch and confirm this issue has been fixed. Please close.

LiuZhexuan avatar Apr 10 '24 02:04 LiuZhexuan

@xiaoyeli Please close this issue as Liu Zhexiuan confirmed it is fixed.

gruenich avatar Jul 22 '24 20:07 gruenich