vue-sonner icon indicating copy to clipboard operation
vue-sonner copied to clipboard

refactor: new changes from sonner

Open sadeghbarati opened this issue 1 year ago • 1 comments

I checked every part of sonner code and brought it here, sometimes this error happens which I don't know how to solve please do have a look and submit a review, please

image

sadeghbarati avatar Aug 01 '24 09:08 sadeghbarati

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ❌ Failed (Inspect) Sep 22, 2024 6:14pm

vercel[bot] avatar Aug 01 '24 09:08 vercel[bot]

@xiaoluoboding Could you please review, Thanks 🙏

sadeghbarati avatar Aug 30 '24 18:08 sadeghbarati

@xiaoluoboding Error seems gone now after updating deps, : |

Can you please test it too? Sorry it is very large PR 🙏

sadeghbarati avatar Sep 22 '24 18:09 sadeghbarati

@sadeghbarati OK, I will check it and test the new changes.

xiaoluoboding avatar Sep 23 '24 02:09 xiaoluoboding

@sadeghbarati I apologize, but this pull request contains significant changes to the code formatting. It appears that we may have different formatting guidelines. Please remove any formatting changes and retain only the logical modifications.

xiaoluoboding avatar Sep 23 '24 02:09 xiaoluoboding

I just used the antfu eslint config and then remove it from deps, ok I'll create the new PR

sadeghbarati avatar Sep 23 '24 05:09 sadeghbarati