TimeCycle icon indicating copy to clipboard operation
TimeCycle copied to clipboard

transform_trans_out

Open AbdallaGomaa opened this issue 6 years ago • 1 comments

I was looking at the transform_trans_out in model_simple.py function and I noticed that the 2D rotation matrix is multiplied by 1/3. Could you please help figure out the reason for that? Shouldn't the 2D matrix be correct as is?

https://github.com/xiaolonw/TimeCycle/blob/16d33ac0fb0a08105a9ca781c7b1b36898e3b601/models/videos/model_simple.py#L148-L151

AbdallaGomaa avatar Aug 27 '19 18:08 AbdallaGomaa

I was looking at the transform_trans_out in model_simple.py function and I noticed that the 2D rotation matrix is multiplied by 1/3. Could you please help figure out the reason for that? Shouldn't the 2D matrix be correct as is?

https://github.com/xiaolonw/TimeCycle/blob/16d33ac0fb0a08105a9ca781c7b1b36898e3b601/models/videos/model_simple.py#L148-L151

Hi Abdalla, I am looking at this code too. I guess this is because the tracked patch size is one-third of the original image size. When transformation theta is fed to the sampling function 'GeometricTnf', you shall expect to get a patch that is one-third of the size of the image. Multiplied by one-third, it does not change the rotation matrix but changes the sampling scale in fact. So that means if you wish to change the size of the sampled patch, the coefficient 1.0/3.0 should be changed accordingly

LeiYangJustin avatar Sep 29 '19 04:09 LeiYangJustin