react-image-gallery icon indicating copy to clipboard operation
react-image-gallery copied to clipboard

Global classes named `left` or `right` overwrite react-image-gallery classes

Open mariokandut opened this issue 3 years ago • 3 comments

Describe the bug Global classes named left or right overwrite react-image-gallery classes

Image Gallery Version 1.2.7

To Reproduce Create a in your global css file a class named left or right and assign it for example width: 50%

Expected behavior react-image-gallery should use custom classNames

Desktop (please complete the following information):

  • OS: Ubuntu 20
  • Browser: chrome

mariokandut avatar Jan 30 '22 19:01 mariokandut

Hi, I'd like to try working on this issue but could use some clarification. Where are the left and right classes that need to be renamed?

ethananselkelly avatar Apr 29 '22 00:04 ethananselkelly

They are in https://github.com/xiaolin/react-image-gallery/blob/master/styles/scss/image-gallery.scss.

The left and right classnames are not specific enough so making it more specific should fix the issue.

xiaolin avatar Apr 29 '22 00:04 xiaolin

@xiaolin Hi! I have fixed this issue in #692, could you please check on that?

Luo-Yihang avatar Aug 10 '22 09:08 Luo-Yihang