Xiaocheng Hu

Results 72 comments of Xiaocheng Hu

It should definitely work with `position: sticky`, but we haven't done the spec work yet: #8448 Would you mind splitting this bug by moving the stickypos related stuff to #8448...

It seems doable to me if we want to additionally apply additional transforms to the anchored element after layout. There are some issues with the transform origin, but they may...

> Could there be cases where there'd be a transform which we don't want to follow? I think this might be the common case. If the style doesn't explicitly have...

Discussed offline, as we should create a ref test to compare the pixel results directly.

@mrobinson Could you take another look at this? Thanks!

The approach in this PR looks really hacky to me. Let's see if we can finish the WebDriver to ServoShell move soon.

Usually we land a hacky fix only if: 1. It's urgency (eg causing issues to users), and will be properly addressed later 2. The root cause is very hard to...

Build on OH failed. Could you fix the usage of `KeyboardEvent` in `ports/servoshell/egl/app_state.rs`?

Sorry for the (huuuuge) delay... The code change looks fine. Now that we've made a lot of improvements to WebDriver, can we add WPT? Is OK to verify them locally...