xi-term
xi-term copied to clipboard
xi-frontend
Sublime-like changes
@msirringhaus do you mind explaining a bit what you added in https://github.com/xi-frontend/xi-term/pull/109/commits/db5488b012b922239bd4a68f60fd99f7dcbcedca ? Where are the cursors rendered here? It seems like what this adds is the ability to select multiple regions corresponding to a search result, is that right?
It seems like what this adds is the ability to select multiple regions corresponding to a search result, is that right?
That is correct. Its the ctrl+d-feature of sublime. You either pre-select some text and press ctrl+d or you press ctrl+d twice to select the current word under the cursor and go from there. Luckily, that is xi-cores behavior too, when trying to "select under cursor" + "find next" with no selection.
Once you have something selected, repeated ctrl+d presses will search for the selected text and add a new cursor there.
Where are the cursors rendered here?
Indeed, they are currently not. xrl is hiding the annotations-part of the update notification from xi-core. In it would be the information of where the cursors are (albeit a bit clumsy to parse out of (see here )
Edit: To clarify: It works, but you can only see the main cursor at the moment
Selecting lines suffers the same issue than https://github.com/xi-frontend/xi-term/pull/99#issuecomment-488005732
Edit: Oh, I see you already commented on that issue here, sorry.
@msirringhaus I've looked at every commit at this point although I just glanced at some, and I played a bit with the editor. This is pretty awesome work, and I'd love to integrate it into xi-term. But as it stands, this PR a bit too big to review properly, and I won't be able to do a good job at merging it. Do you think you could try to split it into smaller PRs and rework the git history so that commits don't have some unrelated changes? (No pressure, I'm not in a hurry).
In principle yes. First off, it might be way less work to just review HEAD as it is. Most of the commits are me reworking my own features a bazillion times. Thus adding a lot of noise which is not visible on HEAD anymore.
But if that is still too big, I could in theory split it up. But do you require for those intermediate commits to actually work and compile? That would be a lot of work, and unfortunately my "work on whatever project you want"-week is now over :-( So time is again limited.