go-simple-mail icon indicating copy to clipboard operation
go-simple-mail copied to clipboard

Weird naming `NewSMTPClient`

Open IceflowRE opened this issue 4 years ago • 3 comments

NewSMTPClient should be NewSMTPServer or at least it should be documented, why this is how it is.

IceflowRE avatar Aug 05 '21 17:08 IceflowRE

I confirm a mistake with names. Also see #37

I will document this in next days.

xhit avatar Aug 05 '21 21:08 xhit

If i could add, its not just the use of the "server" variable, a function called NewSMTPClient returns a SMTPServer Perhaps the function should be changed to NewSMTPServer, although i understand the predicament with that aswell.

Maybe NewSMTPEndpoint?

Just my 2c

Foosec avatar Nov 17 '21 22:11 Foosec

It's time to V3 so make all your ideas here: #53

xhit avatar Nov 18 '21 03:11 xhit