hoist-react Update `react-select 4.3 → 5.x`

They have full TS support now (https://react-select.com/typescript), and some nice improvements to customizing styling of the various components which would clean up some app code which currently has to provide full custom components or have very specific CSS overrides (https://react-select.com/styles#the-classnames-prop)

Also their site does not seem to have a nice archive of the docs for previous versions, which keeps tripping me up as I keep getting confused on what we can use in 4.x.

https://react-select.com/upgrade

Jul 24 '23 12:07 haynesjm42

Agreed, well past time to update!

Reminder that we need to also take the matching upgrade to react-windowed-select - in the past they have lagged a bit with the major updates, but looks like they are on 5.x also.

Jul 25 '23 13:07 amcclain

@leogretz2 -- were we unable to clean up any of our app code with the features they mention?

Aug 04 '23 19:08 lbwexler

@haynesjm42 -- merging this now. We punted on promoting the new classNames property to a hoist prop, but it should be availlable for your use in rsOptions -- let us know how it goes, and if you are using it so extensively that you think it warrants becoming a first class property.

Aug 15 '23 18:08 lbwexler

Looks like this react-windowed-select bug might be cleaned up: https://github.com/jacobworrel/react-windowed-select/issues/19

and that these workarounds could be removed: https://github.com/xh/hoist-react/blob/develop/desktop/cmp/input/Select.ts#L531 https://github.com/xh/hoist-react/blob/develop/desktop/cmp/input/Select.ts#L657

if the matching react-windowed-select upgrade goes well.

Jun 20 '24 19:06 cnrudd