hoist-react
hoist-react copied to clipboard
Use of `openMenuOnFocus` w/inline grid `selectEditor` can result in accidental edit
All I'm doing here is clicking tab
to go from cell-to-cell - note how use of openMenuOnFocus
combined with select
handling of tab key results in a change to the "Type" column value.
This would be VERY easy for a user to miss who is quickly zipping through a grid via common tab
keystroke. We should look to suppress tab handling within inline selects (or block use of openMenuOnFocus
or some other solution...)
https://user-images.githubusercontent.com/225806/170587913-f46eec9d-b332-455c-86dd-fbde8260c2d3.mov
so did some more research on this -- in its current (v49+) incarnation, the select editor in the grid behaves just the way it does in the form with this option.
Which is just to say that tabbing through it will indeed, reset the value, but it will take two tabs to do so (first tab accepts the selected value, second tab moves on)
I think this is still problematic, but the fact is that this is no less problematic in a form, which users may also be tabbing through.
The underlying problem is that we would like the select menu to automatically select and scroll to the current value, rather than the first value.