hoist-react icon indicating copy to clipboard operation
hoist-react copied to clipboard

Extra `<div>` wrapper around `DateInput` DOM prevents setting className, styles on outermost element

Open amcclain opened this issue 3 years ago • 3 comments

The desktop DateInput component renders with an outer <div> element that does not take the className or style props passed to the component - https://github.com/xh/hoist-react/blob/d7a09dfb28b0b893565fe666f40af55aaf6f38f9/desktop/cmp/input/DateInput.js#L391

Often classNames or styles are used for layout concerns like padding or margins, which can't be controlled here. Specifically, I might wish to use a class or style to override the padding applied to a dateInput within a toolbar - that's something that happens at the outermost layer.

I would vote for applying at least className to the outer div. If needed, could support inputClassName, but not sure we really need that.

amcclain avatar May 04 '21 19:05 amcclain