Support percent values in panelModel defaultSize

Open cnrudd opened this issue 5 years ago • 2 comments

The defaultSize property on PanelModel only accepts pixels. It might be more developer friendly if it accepted percent values, where the percent was a percentage of the Panel's parent element.

See: https://github.com/xh/hoist-react/blob/develop/desktop/cmp/panel/PanelModel.js#L69

Apr 28 '20 19:04 cnrudd

After discussion with Lee and Anselm, we have agreed that when it comes to saving a resized panel's new size in panel state, panel size should be: “stored in px if originally specified in px, and stored in % if originally specified in %.”

Jun 08 '20 18:06 cnrudd

Wow -- oldest ticket/PR I have closed in a long time.

Mar 22 '23 18:03 lbwexler