Menu / Split button

[cnrudd]

Hoist P/R Checklist

Please view this branch with this corresponding toolbox branch: https://github.com/xh/toolbox/tree/splitButton (toolbox PR ) Test page is at http://localhost:3000/admin/tests/button in toolbox Demo page is http://localhost:3000/app/forms/toolbarForm in toolbox, to which I've added 3 split buttons.

Pull request authors: Review and check off the below. Items that do not apply can also be checked off to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

• [x] Caught up with develop branch as of last change.
• [x] Added CHANGELOG entry, or determined not required.
• [x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
• [x] Updated doc comments / prop-types, or determined not required.
• [ ] Reviewed and tested on Mobile, or determined not required.
• [x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases. PRs containing a single commit should be rebased when possible.

[amcclain]

Hi @cnrudd - thanks for opening this up.

I took a look and made some updates to discuss. More than anything, this made me realize that we don't have a basic (non-split) menu button in Hoist. I would like to review potential props with @lbwexler this coming week and then get in both the split and non-split buttons to show menus with a common approach.

We should also look at the mobile menu components, which have a model involved and see what we might want to reconcile so we have as common and consistent approach as possible for such a core component. Getting menus into the mainline is long overdue - this is a great prompt to get a first iteration done on that this week. Thanks!

[cnrudd]

Ok, reviewed and ran the changes. All good. Let me know if there's something else you'd like me to do with regard to this.

[amcclain]

Great - thanks for looking. We can touch base with Lee when the three of us have a few moments.

I'd like to review the props as they are for this component, and then decide on a (hopefully) consistent approach that could also add in a menuButton component (exact name TBD). I think that latter component would be more commonly used, although I still want/love splitButton.