Sebastian Bank

Results 48 comments of Sebastian Bank

> You wanna use this structure as output from the covering edges? Yep (just spelling out the earlier quadruple proposal). > My plan is to keep this function as close...

> My first idea was to have something like Lattice.fromconceptlist(list) where list would be ConceptList, > but since fcbo is not returning ConceptList we need some better idea :) Just...

Great news. :) > It needs some tests, where is the best place to write them? Tests are mostly organized by filename, can go here: https://github.com/xflr6/concepts/blob/24e65415834439fb407e80225968b213fdf25d2e/tests/test_algorithms.py#L36 We can also divide...

Thanks. > Where do you think is the best place to give user the ability to change which algorithm will build the lattice? > Since `Context.lattice` is lazyproperty there is...

Thanks. For context: so far we did not expose the underlying bitsets and we are starting to to this with `_common.Concept`. +1 that it's probably confusing that `lattice_members.Concept.extent` of lattice...

See also: https://github.com/xflr6/concepts/blob/c809276020afcd351f8db27911fe07be98bd4914/concepts/lattice_members.py#L381-L389

> I know that lattice_members.Concept.objects has different meaning, maybe i wasn't too explicit :) Hehe, good. I actually had to look it up first.. :) Re: #21, if we expose...

Thanks for the detailed report. This is indeed working as documented, see https://graphviz.readthedocs.io/en/stable/manual.html#quoting-and-html-like-labels Hint: In case you are want to pass arbitrary user input (e.g. for labels), you might want...

Thanks, and +1 to your proposal to add a better visible warning about possivle quoting/escaping gotchas. See 25043ed2b59bfdc1ac60db10a2d526132ed2a4ce. > I learned enough to understand that `graphviz` is just building output...

Thanks, fixed the typo in 4aa4d2441552d72925388e7ce2232c818e91d751.