TonUINO icon indicating copy to clipboard operation
TonUINO copied to clipboard

Makefile, Compiler-Warnungen, PlatformIO-Unterstützung

Open AlexanderWillner opened this issue 5 years ago • 4 comments

Diese Pull Request beinhaltet:

  • Ein Makefile hinzugefügt
  • Compiler-Warnungen entfernt
  • PlatformIO-Unterstützung hinzugefügt
  • Ein Fehler bei leerem EEPROM gefixt

AlexanderWillner avatar Jan 03 '20 21:01 AlexanderWillner

A short note: While I really like to see steps towards PIO compatibility I still recommend removing platformio.ini from the repository (as written in PR #53).

The reason for this is that developers might use different environments configured in this file. For example I do not use an Arduino Nano but a barebone Atmega MCU which results in a different ini.

If the file is part of the repo everyone with a differing platformio.ini will have to manually discard their changes before creating a pull request.

DerTomm avatar Jan 04 '20 10:01 DerTomm

Would it be useful to have a defailt_platformio.ini that contains example settings? Then platformio.ini could be added to .gitignore

Dakkaron avatar Jan 04 '20 11:01 Dakkaron

That's a good idea. What about platformio.ini.example?

DerTomm avatar Jan 04 '20 11:01 DerTomm

I suggest https://github.com/platformio/platformio-core/issues/1590

AlexanderWillner avatar Jan 04 '20 12:01 AlexanderWillner