hetzner-kube icon indicating copy to clipboard operation
hetzner-kube copied to clipboard

Licenses and contribution

Open byteSamurai opened this issue 6 years ago • 9 comments

Hey, In short: I like to contribute. What I am missing atm:

  • [ ] Licenses (file headers as well as license file) are missing names an mail.
  • [ ] Contribution-Guide. Are contributions only welcome as add on?
  • [x] Gitter/Slack something like that to get in touch without open an issue

What rules are there to contribute?

byteSamurai avatar May 13 '18 17:05 byteSamurai

About chat, what about using matrix? If not, I can also provide a rocket.chat hosting.

pierreozoux avatar May 13 '18 21:05 pierreozoux

I don't have any preferences, but as project owner @xetys should take this decision IMHO.

In other projects Gitter was easy to setup and offers a badge, most important aspect! :smile:

byteSamurai avatar May 14 '18 14:05 byteSamurai

gitter chat is there

xetys avatar May 15 '18 12:05 xetys

ps: about contributions. I will do some guidelines when I find the time. In general all kind of contribution is welcome, like fixes, addons, docs etc...

xetys avatar May 15 '18 12:05 xetys

thb I would like group some files into packages and write some tests. Also resolve the separates types. AFAIR is a anti pattern in GO to have a separate type/model file. Also a Makefile is needed IMHO. Doing Fixes? -> No question about it! Of course I will also these things.

If you have no problem with that you will get some PRs soon. Long term I would like to fancy up the CLI respond . Do you have anything in the pipe yet?

byteSamurai avatar May 15 '18 12:05 byteSamurai

It might do not look like this is my first go project ever, but it is :) So don't know the exact pattern of this. Feel free to improve stuff.

About Makefile, don't know if we need one but possibly yes.

I really appreciate all contributions, so no problems :)

xetys avatar May 15 '18 13:05 xetys

Nice! I will do so. Im also not a pro, but did some small projects and eager to train my inner gopher.

byteSamurai avatar May 15 '18 16:05 byteSamurai

@xetys This is very useful! I Imagined I will be using it to deploy kube cluster soon on Hetzner. We are using hetzner a lot. Do you have a milestone to release v1 yet? I'm not a go expert, but probably can help with the docs, example, etc.

lucernae avatar Jun 19 '18 13:06 lucernae

sure @lucernae

feel free to chop through our issues and suggest them for project 1.0, I will check that out and add them to the TODO list

xetys avatar Jun 21 '18 08:06 xetys