johm
johm copied to clipboard
xetorthio
Support for Spring DI, expire. Invert logic for getAll.
Hi Jonathan,
nice work!
Commit "Explicit @SupportAll to use getAll()" (2fb5533062ee8c93c5c3d4ade9bb0450d5a2aa28) fix multiple SADD's (one for each field) and break api, because I thing it's better annotate (with @SupportAll) explicit if getAll needed. I'm not angry, if you disagree (I need this for my project to save space and load :-) ).
Commit "add expire" (ff037b126155f3e62494881fcedfb4b2bdc9c99b) is related to issue #36.
And small commit (4c7394071849ab267755993dfb6574868167fda7) to allow use JOhm with Spring dependency injection with example in README.md (581e73e313b6d8e82f55ab9e557dc0fd8a7149b5).
Best Regard,
Anton
Good stuff Anton! Can you please revert the code-formatting so we can examine the diff's? If you are an eclipse-user, please use this: https://github.com/gsharma/codestyles/blob/master/eclipseCodestyle.xml Thanks for also fixing issue 36. And I think an explicit SupportAll is a very good idea - your SupportAll has my support :)
Do you mean d8d4db1aa388cd0c497f2793cd70ab2e5c294582 (dos2unix JOhmUtils.java, BasicPer...)? There is no changes here. I've used dos2unix, because someone checked windows-style-newlines in and it looks bad (http://img26.imageshack.us/img26/8238/screenshotby.png).
But if you will, I can revert it (or better: checkout you trunk and apply others commits to keep code cleaner).
That should have been me having made a change from another machine that was running windows. If you are using eclipse for an ide, after running dos2unix, you can run the eclipse code formatter: https://github.com/gsharma/codestyles/blob/master/eclipseCodestyle.xml
Is there a chance for this patch to make it to the repository anytime soon? I'm eager to try the library in conjunction with Spring but if the project won't be maintained regularly then my only option is to start using the forked repository. The lack of official Maven artifact makes this decision even easier.
Thanks!
Yes, we are planning another JOhm release. It will also include an update to Jedis v2. mvn artifact is something we had explored last year but it would require a change to the package structure, so, we backed off on doing that.