Fabian Schuh

Would it be possible to add unit tests for those?

Instead of calling those methods _rewrite, can we have them `fromBytes()` and not begin with `_`. That makes it more obvious and corresponds better with the `fromBuffer` used in bitsharesJS

Did you encrypt the key with this lib too? I think the standard is a bit wider than what is supported in this lib

Also curious about this discussion. I always wondered if we could adopt Steem's moving average concept, but always though it wouldn't work well in combination with margin calls. I always...

From the other issue: > So, adding a user-defined order-id would IMHO require > > * a hardfork to add the user-defined id to the `create_limit_order` operation > > *...

> Publishing version information is a security risk. And how about only putting `major` on chain? I kind of disagree on requiring every node operator (including non block producers) to...

I dont real the BSIP like it wanted to REMOVE the feature but rather unlink it from STEALTH token. Thus the stealth operations would become 'regular' operations that pay to...

> IMO it's a bad idea to use a PGP-like plain string representation, precisely because PGP has had a lot of difficulties with this. At the very least, you must...

> How is the string hashed? Transaction hashing prepends the chain ID, is that also required here? Yes, it does - and IMHO should because accounts on different chains could...

Would it make sense to start integrating the account recovery feature that steem has? That way, he could challenge the new owner role and have the previous installed again ..