Bad use of OutOfMemoryError to validate buffer size

[duongkame]

In SnappyInputStream, OutOfMemoryError is used to validate the buffer size to allocated. https://github.com/xerial/snappy-java/blob/dfbf67a4cb49930aa7be2bf6c6d9e77e6aba79e2/src/main/java/org/xerial/snappy/SnappyInputStream.java#L451-L456

This's a bad way to validate buffer size as explain here.
And another serious consequence, catching OutOfMemoryError in Java code requires the applications not to use JVM options like CrashOnOutOfMemoryError or ExitOnOutOfMemoryError to automatically restart the JVM when it runs out of memory.

I'm wondering if there is a specific reason why that could not be a simple conditional validation?

[xerial]

There wasn't any specific reason for that. It's better to be fixed as you suggested.

[duongkame]

Thanks for your reply @xerial. I filed a PR: https://github.com/xerial/snappy-java/pull/647/files.

[xerial]

Fixed in #647. Thanks!