Taro L. Saito

Results 287 comments of Taro L. Saito

@garyelephant, I cannot undertake such an investigation work for free as my time is limited. Can you provide a reproduction and propose a fix?

libsnappyjava.so file is a bit different from libsnappy.so because of some extensions. To see which snappy version is used, see this file https://github.com/xerial/snappy-java/blob/master/src/main/resources/org/xerial/snappy/VERSION

@maropu What do you think?

Do you mean adding `-Wl,dynamicbase, -Wl,nxcompat` compiler flags?

See the compatibility note here: https://github.com/xerial/snappy-java#compatibility-notes We can use SnappyHadoopCompatibleOutputStream to generate Hadoop Snappy compatible compressed stream.

What is a suggested fix? `bundle` seems valid for OSGi support. I'm not sure how Maven is handling pom or bundle differences.

Good cath. Targeting JDK8 should be no problem. Whenever you have time, I'd appreciate a PR for the fix.

I understand this pain, but snappy-java has an API for knowing the max compressed length (this can be larger than the input data size!): https://oss.sonatype.org/service/local/repositories/releases/archive/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7-javadoc.jar/!/org/xerial/snappy/Snappy.html#maxCompressedLength-int- And also `byte[] Snappy.compress(byte[] input)`...

Enabling pure-java mode would help for supporting alpine https://github.com/xerial/snappy-java#using-pure-java-snappy-implementation. This is available since 1.1.7.6