peridot icon indicating copy to clipboard operation
peridot copied to clipboard

Support :same-site attribute

Open jeroenvandijk opened this issue 2 years ago • 2 comments

Please find the following changes in this PR:

  • [X] Update ring-core test dependency to make it aware of cookie attribute :same-site (link)
  • [X] Add CI build script (as Travis.org seems to be EOL) #54
  • [X] Add Failing test to showcase missing implementation #55
  • [X] Add implementation for :same-site attribute
  • [X] Fix CI (see builds of this fork)

I can split up these commits in seperate PR's if desired.

For full support we might also need to consider updating kerodon for when following links, this should have the same behaviour as redirects in peridot (see for more explaination this page under Differences Between the Strict and Lax SameSite Cookie Attributes

jeroenvandijk avatar Jun 07 '22 14:06 jeroenvandijk

Sorry I missed this PR. Could we use GitHub Actions? Everything else looks ok.

danielcompton avatar Nov 06 '23 08:11 danielcompton

I removed the CI part. So this can be tackled separately.

jeroenvandijk avatar Nov 13 '23 10:11 jeroenvandijk