xeokit-sdk icon indicating copy to clipboard operation
xeokit-sdk copied to clipboard

Transform to Monorepa with Lerna

Open kvandake opened this issue 3 years ago • 8 comments

kvandake avatar Nov 17 '22 07:11 kvandake

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Nov 17 '22 07:11 ghost

Looking good! We just need to plan a couple of things on our end before merging, since we'll be introducing a bunch of new package names into the SDK now ;)

xeolabs avatar Nov 19 '22 23:11 xeolabs

@xeolabs We are transforming all packages. Please see it.

kvandake avatar Dec 27 '22 15:12 kvandake

@kvandake looks good to me - I just created a new branch called 'monorepo' - could you please remake this PR against that branch?

In that branch, I've also made all the examples load the binaries from a CDN, instead of the ./dist directory. This will also help us not to disrupt those who are relying on the single binary.

xeolabs avatar Jan 19 '23 11:01 xeolabs

I changed target branch. What are the next steps?

kvandake avatar Jan 25 '23 08:01 kvandake

Next steps on my end:

-merge

  • test
  • update all the documentation
  • publish npm modules, update various links
  • update dependent applications

So once I've merged, I'll publish npm packages from that branch as perhaps "beta" and when they're all good, and docs updated, I'll merge into master.

xeolabs avatar Jan 25 '23 15:01 xeolabs

Hello @xeolabs! When are you planning merge this MR?

kvandake avatar Apr 24 '23 07:04 kvandake

Hi @kvandake, it's coming! I just need to do the next release as a normal repo this week or next, because some users expect it.

Then after that, I'll apply this PR. I've actually taken your lead on this and used Lerna for xeokit V3 (https://github.com/xeokit/sdk) and it's working well there.

So we're considering Lerna essential and merging is next priority, I expect within the next two weeks.

xeolabs avatar Apr 24 '23 20:04 xeolabs