xscontainer icon indicating copy to clipboard operation
xscontainer copied to clipboard

Error in error handling if no IP address is found

Open stormi opened this issue 5 years ago • 3 comments

This line of code fails when executed, with message AttributeError: 'module' object has no attribute 'ERROR_CAUSE_NETWORK' https://github.com/xenserver/xscontainer/blob/master/src/xscontainer-prepare-vm#L80

See this bug reported by a user of XCP-ng, with full backtrace: https://github.com/xcp-ng/xcp/issues/198

I don't know the code of xscontainer enough to provide a patch, but the fix should be easy.

stormi avatar Jun 11 '19 14:06 stormi

Ping?

stormi avatar Apr 20 '20 11:04 stormi

Meh Same here

LunarstarPony avatar Mar 27 '21 03:03 LunarstarPony

Looks like this was introduced by commit 28142802a4049ae9cd45aaae65cb8e9a8692ed19 when they were separating out some functionality. I don't have time to test right now, but line 80 should probably be modified to be print(remote_helper.ssh.ERROR_CAUSE_NETWORK)

dalrrard avatar Sep 27 '21 16:09 dalrrard