xe-guest-utilities icon indicating copy to clipboard operation
xe-guest-utilities copied to clipboard

How to contribute to install.sh?

Open stormi opened this issue 5 years ago • 6 comments

The install.sh script from Citrix Hypervisor's guest tools ISO does not seem to be available on github. I'd like to contribute a fix that was contributed to me by a user of XCP-ng, but I don't know how.

stormi avatar Jun 05 '19 15:06 stormi

Hi, this script is not located in source repo. Actually, we put it when packaging. Could you please comment where is the specific fix? Thank you.

minli1 avatar Jun 06 '19 02:06 minli1

There's no way you could make it part of the repo and use it from there when packaging?

Anyway, here's the patch. I'm waiting for the user who reported the bug to test it.

https://github.com/xcp-ng/xe-guest-utilities/commit/c8625f1d837ed182fa299373f047ab3034d0cc39

stormi avatar Jun 06 '19 08:06 stormi

I checked the patch and luckily we have log an issue and the fixing/testing in progress. I think it will be released soon. BTW, I will create an improvement ticket to move the install script to code repo anyway. Thank you.

minli1 avatar Jun 10 '19 02:06 minli1

Hi. I'm currently trying to repackage the tools. Have things moved on towards the migration of the install script to this repo?

stormi avatar Feb 08 '21 17:02 stormi

Hi @stormi , We are going to move install.sh into this repo soon, we have a task internal to track this.

xihuan-citrix avatar Feb 09 '21 02:02 xihuan-citrix

Hi @stormi , We are going to move install.sh into this repo soon, we have a task internal to track this.

Hi! This was two years ago. Is it still planned soon?

stormi avatar Jan 31 '23 09:01 stormi