whisper-web icon indicating copy to clipboard operation
whisper-web copied to clipboard

Published 20 hours ago • verified publisher icon xenova

Upgrade dependencies

Open PierreMesure opened this issue 8 months ago • 7 comments

Hi @xenova,

As promised, I'll try to contribute some of the changes from my fork back to the main project. I suggest to start from your branch experimental-webgpu (which seems to be the latest one), reintegrate lost functions from main (such as wasm inference) and then merge it back in main. Then I will send PRs with the new functions.

I'll try to break the changes into small PRs so you can quickly review and approve them. I start with this one. It just contains dependency updates.

PierreMesure avatar Feb 26 '25 20:02 PierreMesure

Hi @xenova, I'd like to merge these PR to continue working on improving the main branch. I understand if you don't have time to review them though.

What do you think of making me a maintainer for this repo? I'd be happy to try and triage some of the previous PRs, look at the Issues, on top of adding the features we discussed here.

PierreMesure avatar Mar 01 '25 06:03 PierreMesure

Hi @xenova, I would appreciate at least a sign from you. Otherwise, I'll pause my PRs here, I don't want to ask you to review things that you don't have time to look at. 🙂

PierreMesure avatar Mar 05 '25 09:03 PierreMesure

Hey @PierreMesure! 👋 My bad, I should have commented on the PRs as they came in :) I'll definitely make time to review them! At the moment, I'm just rushing to finalize Transformers.js v3.4 before Friday 🫡

xenova avatar Mar 05 '25 12:03 xenova

Thank you Joshua! It's good to know you've got it in your backlog! Good luck with the release!

PierreMesure avatar Mar 06 '25 10:03 PierreMesure

I tried to upgrade the dependencies again before you merge this PR and I now get an error message using transformers.js 3.4.0.

An error occurred: "token_ids must be a non-empty array of integers.".

This doesn't happen with 3.3.3.

You can easily reproduce it on this branch by upgrading transformers.js.

PierreMesure avatar Mar 08 '25 20:03 PierreMesure

Hi @xenova. I'm sorry to see that you don't have time to review these PRs. I'm sure you have more important things to do and that's OK, you are in no way forced to review or accept external contributions.

I was hoping to contribute as much as I could to your parent repo rather than letting my fork stray too far from it. But I don't want to be stuck waiting so I will focus on my fork from now on.

I might reconsider and contribute again if you have more time to merge PRs or accept to delegate the work to other people. Your repository has visibility and its code is used by many so I think it's meaningful to contribute to it.

PierreMesure avatar Mar 18 '25 16:03 PierreMesure

Hi @xenova. I'm sorry to see that you don't have time to review these PRs. I'm sure you have more important things to do and that's OK, you are in no way forced to review or accept external contributions.

I was hoping to contribute as much as I could to your parent repo rather than letting my fork stray too far from it. But I don't want to be stuck waiting so I will focus on my fork from now on.

I might reconsider and contribute again if you have more time to merge PRs or accept to delegate the work to other people. Your repository has visibility and its code is used by many so I think it's meaningful to contribute to it.

Thanks @PierreMesure 🤗 Thanks for understanding - I've been quite busy these past few weeks, but things should be returning to normalcy now 🤞 I guarantee that the next PR merged will be yours! 😇

xenova avatar Mar 29 '25 17:03 xenova