transformers.js icon indicating copy to clipboard operation
transformers.js copied to clipboard

Cache path vs Local path

Open axrati opened this issue 1 year ago • 9 comments

This aims to fix an issue where providing a directory for a model in a different parent directory/tree results in an error.

There is a split handling between cache path and local path - mostly because I wasn't sure behind all use case implementations (browser vs local vs X). This solutions solves providing file paths such as ../../your_model_dir as the env.localModelPath variable.

axrati avatar Feb 22 '24 23:02 axrati

@xenova

axrati avatar Feb 29 '24 02:02 axrati

@xenova

axrati avatar Mar 13 '24 18:03 axrati

@xenova

Xenova is currently overwhelmed with the release of v3, but will for sure review your PR as soon as possible. Don't worry, your PR won't be left behind.

felladrin avatar Mar 14 '24 08:03 felladrin

Thank you! Happy to help however I can (PR's / Issues / etc), please let me know how to contribute best 😃

axrati avatar Mar 14 '24 14:03 axrati

@felladrin @xenova

Hi! This has been open for a bit... its a small change I promise :)

Fixes issues in this issue (multiple people are experiencing): https://github.com/xenova/transformers.js/issues/520

axrati avatar Apr 18 '24 20:04 axrati

@felladrin @xenova

Following up on this! Please let me know how to move forward with your merging process?

axrati avatar May 22 '24 23:05 axrati

Sorry it hasn't been merged yet, @axrati. But only Xenova can make it.

felladrin avatar May 24 '24 10:05 felladrin

@xenova following up on this!

axrati avatar Jun 11 '24 23:06 axrati

@xenova @felladrin following up on this!

axrati avatar Jul 16 '24 20:07 axrati