transformers.js icon indicating copy to clipboard operation
transformers.js copied to clipboard

Add model file name

Open NawarA opened this issue 1 year ago • 6 comments

NawarA avatar Feb 20 '24 17:02 NawarA

@xenova here's the promised PR for #509

I'll try to expand the solution to encoder-decoder models once I begin working with them.

NawarA avatar Feb 20 '24 18:02 NawarA

In the PR, you'll see my system trimmed white spaces, and the only change is:

image

NawarA avatar Feb 20 '24 18:02 NawarA

Thanks for the PR! Just to keep the diff small, can you remove any whitespace formatting applied by your editor? There definitely are valid changes, but it will make the diff large for the PR. 🤗

xenova avatar Feb 24 '24 13:02 xenova

Thanks for the PR! Just to keep the diff small, can you remove any whitespace formatting applied by your editor? There definitely are valid changes, but it will make the diff large for the PR. 🤗

@xenova Absolutely. Done.

Thanks for the suggestion. The PR now has two lines changed. Much cleaner!

The PR is also merged with 2.16.0 (released a few hours ago), and is ready to go :)

NawarA avatar Mar 07 '24 18:03 NawarA

The PR is merged with 2.16.1 and is ready to go :)

NawarA avatar Mar 24 '24 18:03 NawarA

@xenova Those changes are already in v3. This PR should be merge into main, or close until v3 arrives

Th3G33k avatar May 09 '24 15:05 Th3G33k

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

I'll try to expand the solution to encoder-decoder models once I begin working with them.

I'll make the necessary changes in v3 myself. For now, this is okay (and will work for all single-file models, like encoder-only and decoder-only models).

xenova avatar May 23 '24 10:05 xenova