chat-downloader
chat-downloader copied to clipboard
Some improvements
This PR adds the following improvements to the project:
- Added superchat to default message groups of YouTube (was #126, closed due to unwanted commit got pushed, see #126-comment)
- Changed the default value of the
title
attribute of theChat
object fromNone
to an empty string (see #126-comment) - Changed to set the exit status to 1 if any error caused the program to exit
For 1 and 2, please see the referred PR and comment.
For 3, the current implementation will set the exit status to 1 on any exceptions raised, including the KeyboardInterrupt
. However, if you want to set different exit statuses for different exceptions, the value can be customized by returning directly at the end of each except
block. This can be useful when waiting for the chat to become available using a while
loop in the shell, if the chat was disabled until the live started. Given that the project doesn't have a built-in solution for waiting for the chat to become available, this small change would solve the problem with minimal effort, and it is also a common practice to set the exit status of a program to non-zero values if the exit was caused by errors.
@xenova Sorry for pinging you. Would you like to review this pr and see if it can be merged to the repo? You could also close this pr if you don't, but I've been waiting for a response for over half a year.